Skip to content

TST: Check merging on equivalent CategoricalDtype #25898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

TST: Check merging on equivalent CategoricalDtype #25898

merged 1 commit into from
Mar 28, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Mar 28, 2019

Closes #22501

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Reshaping Concat, Merge/Join, Stack/Unstack, Explode Categorical Categorical Data Type labels Mar 28, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone Mar 28, 2019
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #25898 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25898      +/-   ##
==========================================
+ Coverage   91.53%   91.53%   +<.01%     
==========================================
  Files         175      175              
  Lines       52808    52808              
==========================================
+ Hits        48338    48339       +1     
+ Misses       4470     4469       -1
Flag Coverage Δ
#multiple 90.09% <ø> (ø) ⬆️
#single 41.82% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 90.56% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882961d...b693f2d. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 28, 2019 •
edited
Loading

Codecov Report

Merging #25898 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25898      +/-   ##
==========================================
+ Coverage   91.53%   91.53%   +<.01%     
==========================================
  Files         175      175              
  Lines       52808    52808              
==========================================
+ Hits        48338    48339       +1     
+ Misses       4470     4469       -1
Flag Coverage Δ
#multiple 90.09% <ø> (ø) ⬆️
#single 41.82% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 90.56% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882961d...69eda22. Read the comment docs.

jschendel
jschendel reviewed Mar 28, 2019
View reviewed changes
@gfyoung gfyoung force-pushed the merge-equal-cat-dtypes-test branch from 62813ae to 69eda22 Compare March 28, 2019 08:10
@jreback jreback merged commit 8b9f933 into pandas-dev:master Mar 28, 2019
@jreback
Copy link
Contributor

jreback commented Mar 28, 2019

thanks!

@gfyoung gfyoung deleted the merge-equal-cat-dtypes-test branch March 29, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jschendel jschendel jschendel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Categorical Categorical Data Type Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

0.25.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gfyoung @jreback @jschendel